Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change: Improve clarity in docs/06-responses.md #2853

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Small change: Improve clarity in docs/06-responses.md #2853

merged 1 commit into from
Aug 28, 2024

Conversation

aznszn
Copy link
Contributor

@aznszn aznszn commented Aug 24, 2024

I was reading the docs and thought the wording here could be improved.

SergioBenitez
SergioBenitez reviewed Aug 25, 2024
View reviewed changes
Copy link
Member

@SergioBenitez SergioBenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? Is this clearer? I think saying "sends" might imply that the response is actually sent to the client, which it isn't.

docs/guide/06-responses.md Outdated Show resolved Hide resolved
@aznszn
Copy link
Contributor Author

aznszn commented Aug 25, 2024

How about this? Is this clearer? I think saying "sends" might imply that the response is actually sent to the client, which it isn't.

Yes this is much clearer

@SergioBenitez SergioBenitez merged commit de6632e into rwf2:master Aug 28, 2024
16 checks passed
@aznszn aznszn deleted the patch-1 branch September 4, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioBenitez SergioBenitez SergioBenitez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aznszn @SergioBenitez